Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 156
    • Merge requests 156
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !54885

ATLASRECTS-7136: Fix for cases where impact parameter calculation fails

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dan Guest requested to merge dguest/athena:fix-for-badip into 22.0 Jul 06, 2022
  • Overview 30
  • Commits 12
  • Pipelines 8
  • Changes 17

For reasons that aren't completely clear at the moment, the impact parameter calculation we usually use for b-tagging sometimes fails. The result is that we enter nonsense values, which DIPS consumes, which then become NAN in the DIPS outputs, which throws an error in DL1d.

I'm fixing this by adding a flag on tracks that have an invalid IP, which then signals DIPS to pass through an isDefaults flag so that DL1d can set defaults on the DIPS inputs.

Edited Jul 06, 2022 by Dan Guest
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-for-badip