Skip to content

Synchronise CA with old-style config, and fix some mistakes : part 2

Edward Moyse requested to merge emoyse/athena:22.0_yet_more_CA_synch_fixes_6 into 22.0

This MR is another attempt to reduce the output differences when running CA compared to old-style configuration. Since this is not on by default, it will have no impact on existing production.

It should not be merged until !54998 (merged) is in, since it depends on commits in this MR.

I tested this locally with the q445 test (link) and this reduces the difference from !54998 (merged) to:

muon1pt: 8 events (out of 100)
muon1eta: 1 events (out of 100)
muon1phi: 2 events (out of 100)

The MR contains the following types of commits.

  • Fix naming of various tools to match old-style
  • Set Cosmics correctly in MuidCaloEnergyToolParamCfg
  • Cleanup use of MuonTrackCleanerCfg and MCTBSLFitterCfg
  • Fix for MuidCaloEnergyParam calling wrong tool
  • In MuonExtrapolatorConfig, we only need one import of AtlasSTEP_PropagatorCfg
  • MuonRefitToolCfg should use MCTBFitterMaterialFromTrackCfg
  • MCTBFitterCfg should have GetMaterialFromTrack True

Edit: closed and reopened to fix the branch to merge into!

Edited by Edward Moyse

Merge request reports