Skip to content

Patch to truth derivation configuration

Zach Marshall requested to merge zmarshal/athena:TRUTHPatch into master

This solves the first obvious crash in truth derivation production in master with Derivation_tf.py . The next issue is a component accumulator problem that I'm less familiar with. This crash can be seen in ART:

https://bigpanda.cern.ch//media/filebrowser/6143079b-2a15-4c05-b5b8-210f01614dbb/group.art/tarball_PandaJob_5524142418_CERN-T0/log.Derivation

which is just a good old fashioned undefined variable:

22:27:19 RuntimeError: No such flag: Sim.SimBarcodeOffset The name is likely incomplete.

which is fixed with this MR. The next crash, which I haven't fixed but am leaving here for reference, is:

Derivation 23:32:40   File "/tmp/zmarshal/test0/run/./runargs.Derivation.py", line 39, in <module>
Derivation 23:32:40     fromRunArgs(runArgs)
Derivation 23:32:40   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc11-opt/2022-07-11T2101/Athena/23.0.4/InstallArea/x86_64-centos7-gcc11-opt/python/DerivationFrameworkConfiguration/DerivationSkeleton.py", line 79, in fromRunArgs
Derivation 23:32:40     cfg.merge(derivationConfig(ConfigFlags))
Derivation 23:32:40   File "/tmp/zmarshal/test0/build/x86_64-centos7-gcc11-opt/python/DerivationFrameworkMCTruth/TRUTH3.py", line 15, in TRUTH3Cfg
Derivation 23:32:40     acc.merge(AddStandardTruthContentsCfg(ConfigFlags))
Derivation 23:32:40   File "/tmp/zmarshal/test0/build/x86_64-centos7-gcc11-opt/python/DerivationFrameworkMCTruth/MCTruthCommonConfig.py", line 209, in AddStandardTruthContentsCfg
Derivation 23:32:40     if isEVNT: acc.merge(AddTruthEnergyDensityCfg())
Derivation 23:32:40   File "/tmp/zmarshal/test0/build/x86_64-centos7-gcc11-opt/python/DerivationFrameworkMCTruth/MCTruthCommonConfig.py", line 402, in AddTruthEnergyDensityCfg
Derivation 23:32:40     acc.addEventAlgo(EventDensityAthAlg("DFCommonTruthCentralEDAlg", EventDensityTool = DFCommonTruthCentralEDTool ))
Derivation 23:32:40   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc11-opt/2022-07-11T2101/Athena/23.0.4/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaCommon/ConfigurableMeta.py", line 102, in __call__
Derivation 23:32:40     cfg = cls.__new__( cls, *args, **kwargs )
Derivation 23:32:40   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc11-opt/2022-07-11T2101/Athena/23.0.4/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaCommon/Configurable.py", line 186, in __new__
Derivation 23:32:40     cls.__init__( conf, *args, **kwargs )
Derivation 23:32:40   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc11-opt/2022-07-11T2101/Athena/23.0.4/InstallArea/x86_64-centos7-gcc11-opt/python/EventShapeTools/EventShapeToolsConf.py", line 65, in __init__
Derivation 23:32:40     setattr(self, n, v)
Derivation 23:32:40   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc11-opt/2022-07-11T2101/Athena/23.0.4/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaCommon/PropertyProxy.py", line 253, in __set__
Derivation 23:32:40     value = self.convertValueToBeSet( obj, value )
Derivation 23:32:40   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/master_Athena_x86_64-centos7-gcc11-opt/2022-07-11T2101/Athena/23.0.4/InstallArea/x86_64-centos7-gcc11-opt/python/AthenaCommon/PropertyProxy.py", line 355, in convertValueToBeSet
Derivation 23:32:40     raise TypeError( "Property %s value %r is not a %s nor a %s nor a string" % \
Derivation 23:32:40 TypeError: Property DFCommonTruthCentralEDAlg.EventDensityTool value EventDensityTool('DFCommonTruthCentralEDTool', JetAlgorithm='Kt', JetRadius=0.5, InputContainer=DataHandle('PseudoJetJetInputTruthParticles','R','PseudoJetContainer'), AbsRapidityMin=0.0, AbsRapidityMax=1.5, AreaDefinition='Voronoi', VoronoiRfact=0.9, OutputContainer=DataHandle('TruthIsoCentralEventShape','W','xAOD::EventShape_v1'), UseFourMomArea=True) is not a ConfigurableAlgTool nor a PrivateToolHandle nor a string
Derivation 23:32:40 leaving with code 1: "failure"

@jcatmore , I'm not sure if you've already fixed this privately?

Cheers, Zach

Merge request reports