Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 180
    • Merge requests 180
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !55060

Draft: Make pseudo data handling in JetUncertainties tool nicer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Tadej Novak requested to merge tadej/athena:pseudo-data-jets into 21.2 Jul 13, 2022
  • Overview 27
  • Commits 1
  • Pipelines 0
  • Changes 6

Make pseudo data handling in JetUncertainties tool nicer. It still requires two sets of tools, but one now only sets up JER systematics and suffixes them with PseudoData.

CP algorithms have been updated using AnalysisTop notation, e.g. setting JEROption = "Full_PseudoData".

Open questions:

  • I now rely on string manipulations only on CP::SystematicVariation as I assume original names are needed for histogram loading.
  • How to skip JES systematics reliably?
  • If both tools are configured, both tools are called as nominal running seems to be a void operation, is this problematic?
  • A related question for @krumnack: how to check in a proper way that the CP::SystematicSet that we get from the loop is affecting the tool? At the moment only CP::SystematicVariations can be checked in the interface using isAffectedBySystematic.

Tagging many people: @jburr for CP algs, @mswiatlo, @camacho, @schaarsc and @sawyer for jets, @omajersk and @mrimoldi as they may be interested in that for AnalysisTop/SUSYTools (feel free to tag more people if I have forgotten some).

Keeping Draft for now to allow some discussion.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pseudo-data-jets