Skip to content

AthenaMonitoringKernel: deregistration fixes for LB histograms

Frank Winklmeier requested to merge fwinkl/athena:lbhist into 22.0

Implement proper thread-safe cleanup of old LB histograms. The previous code only kept one histogram alive, which is too short with a publication interval that is larger than the lumiblock (ADHI-4905).

Now we are keeping histograms alive that belong to a fixed number of lumiblocks (currently set to 5). This could be made configurable, but for the moment this number is hard-coded.

The code is using a simple std::map with std::mutex. If this turns out to be too slow we could look into using a concurrent container.

Relates to ADHI-4905, ATLASDQ-780, ATR-25564.

cc @tbold @salnikov @rbielski

Edited by Frank Winklmeier

Merge request reports