Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !55152

NSWCalibTool - Replace suspicious TF1 by the std::function equivalent

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Johannes Junggeburth requested to merge jojungge/athena:ReplaceLorentzTF1_ByStdFunc into 22.0 Jul 16, 2022
  • Overview 33
  • Commits 3
  • Pipelines 0
  • Changes 7

Hi everybody,

  • Although TF1::Eval claims to be a const method, it's always worth to have a closer look into its guts . As you can see, it calls a non-const function which is super suspicious to me. Given that the NSWCalibTool just uses it for a polynomial evaluation, it's better to replace it by a std::function.

ATLASRECTS-7101/ATLASRECTS-7107/ATLASRECTS-7149

Tagging: @pscholer, @chchau

Edited Aug 25, 2022 by Johannes Junggeburth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ReplaceLorentzTF1_ByStdFunc