Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !55157

Restructure emulation tool for r22.0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Carlo Varni requested to merge cvarni/athena:restructure_emulation_tool_r220 into 22.0 Jul 17, 2022
  • Overview 11
  • Commits 6
  • Pipelines 1
  • Changes 12

First restructure of the TrigBtagEmulationTool. The code changes turned out to be more estensive than I was expecting at first. This is mainly just a move around of the code written by @lbeemste and removal of unused pieces of code.

Quite a big MR... it includes the following:

  • Introduction of an EmulContext that acts as a storage for jet collections (and of any kind of collection we may want to store in the future). It contains an unordered_map<std::string, std::unique_ptr<IHolder>>, the JetManagers will store and retrieve collections from here
  • TrigBtagEmulationJet only stores the jet quantities, as well as a pointer to the original jet and b-tagging objects (takes no ownership)
  • TrigBtagEmulationChain only parse the trigger chain definition and stores the set of criteria
  • JetManager retrieves jets from the EventContext and stores in the EmulContext a vector of TrigBtagEmulationJet. This is obtained by merging jets and b-jets collections (<jet-collection-name> + <jet-collection-name>"_bJets")
  • TrigBtagEmulationTool: moved as many methods to this class. It also owns the NN for FlavourTaggingDiscriminant

Moreover:

  • Change of the tool's interface
  • Converted presel jets struct to TrigBtagEmulationJet
  • Removed support for navigation since it is not used
  • Remove support for L1 jets, since for now L1 is not emulated
  • Removed JetManagers for EMTopo jets (kept for presel though)
  • b-tagging wps are taken directly from https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TrigHypothesis/TrigBjetHypo/python/TrigBjetBtagHypoTool.py and passed to the tool in the JO
  • Remapping for NN is configured in the JO instead of hardcoded
  • BTaggingLink can be configured in the JO, default is btaggingLink

tagging @dguest

Edited Jul 23, 2022 by Carlo Varni
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: restructure_emulation_tool_r220