Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 175
    • Merge requests 175
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !55217

InDetCaloClusterROISelector: Fix potential vector overrun.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Scott Snyder requested to merge ssnyder/athena:overrun.InDetCaloClusterROISelector-20220719 into 22.0 Jul 19, 2022
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

ROIPhiRZContainer::addROI can actually make two entries in the vector, if the ROI is close to +-pi. But if this happens. the length we've set for max_output in CaloClusterROIPhiRZContainerMaker::execute may be too small, leading to writes past the end of the vector. We print a warning in that case, but by then it's too late.

Resize max_output if needed, and remove the warning, since it can normally happen. (Leave it commented out for documentation.)

See ATLASRECTS-7160.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: overrun.InDetCaloClusterROISelector-20220719