Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 177
    • Merge requests 177
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !55487

Legacy ISF Configuration Module Renaming (Preparation for ComponentAccumulator Migration)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:ISF_ConfigRenaming_22.0 into 22.0 Jul 28, 2022
  • Overview 19
  • Commits 15
  • Pipelines 3
  • Changes 33

The old-style simulation configuration uses ConfiguredFactory. This uses configuration methods defined in ...Config.py modules which are associated with a component name in various PackageNameConfigDb.py modules.

The new ComponentAccumulator-based configuration tends to use ...Config.py as the naming convention for the configuration modules, but in Simulation we have typically used ...ConfigNew.py to avoid a naming clash. This MR renames all the ConfiguredFactory ...Config.py modules to ...ConfigLegacy.py. Will rename the ComponentAccumulator-based modules in a follow-up merge request, but I wanted to avoid this one getting too large.

Edited Aug 01, 2022 by John Derek Chapman
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ISF_ConfigRenaming_22.0