Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 156
    • Merge requests 156
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !55503

Address crashes in the TrigInDetMonitoring when running multi-threaded

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Sutton requested to merge sutt/athena:prot into 22.0 Jul 28, 2022
  • Overview 8
  • Commits 1
  • Pipelines 1
  • Changes 3

When running in multithreaded mode the scheduler very likely does not respect the proper use of the ReadHandle method with no RedHandleKey - a call to ReadHandle might return the collection before it has been produced leading to a corrupt collection when the requesting algorithm accesses the ReadHandle.

In practicem, such a ReadHandle call should lock until the collection has been produced, else this call can not work. However, as a workaround, we add a dummy ReadHandleKey that, once initialised, should mean that the scheduler only executes the monitoring after the tracking has completed - the actual ReadHandle call does not need to use this RHKey.

This partly addresses ATR-25821

Edited Jul 28, 2022 by Mark Sutton
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: prot