Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !55942

Store full name temporarily when caching Configurables as input to...

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Teng Jian Khoo requested to merge khoo/athena:22.0-TMMT-MuonTPBug into 22.0 Aug 16, 2022
  • Overview 8
  • Commits 2
  • Pipelines 1
  • Changes 1

As seen in ATR-25996, incorrect retrieval could occur if the kwargs of a function called through RecoFragmentsPool were compared by pointer value.

This workaround should help by explicitly including the type and name of each Configurable as an extra entry in the tuple used for cache retrieval, and then dropping this when passing the args to the function call. I'm a bit surprised that this comparison happens actually, I thought we had sorted this out by adding a __hash__ function. But at least this workaround seems to solve the problem in this case and should otherwise be harmless.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 22.0-TMMT-MuonTPBug