Skip to content
Snippets Groups Projects

AnalysisTop: Separate reco and trigger input folder for SFs for muons

Merged AnalysisTop: Separate reco and trigger input folder for SFs for muons
tdado/athena:AnalysisTop-SeparateMuonTriggerFolder into master
All threads resolved!
Merged Tomas Dado requested to merge tdado/athena:AnalysisTop-SeparateMuonTriggerFolder into master
All threads resolved!

Currently, one path can be set for both reco and trigger folder, this is suboptimal as the reco SFs will be available shortly, but not the trigger ones. Thus, separating the config options.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Oliver Majersky resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)AF3.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash c129bdb5)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57561]

  • Rui Yuan added analysis-review-approved label and removed analysis-review-required label

    added analysis-review-approved label and removed analysis-review-required label

  • Joseph Haley
    Joseph Haley @jhaley ·
    Developer

    I would have had the same comment as @omajersk , but looks like it is actually okay, so MR looks good and CI passed, so marking approved. ~Joe (L2)

  • Joseph Haley added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Tadej Novak merged

    merged

  • Tadej Novak mentioned in commit e3224bc9

    mentioned in commit e3224bc9

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply