Cleanup in photon efficiency correction

I will soon do some development in PhotonEfficiencyCorrection, in particular I'll improve the StatusCodes. In preparation of this I'm cleaning up a few things:

• I don't think the calculate functions are used by the enduser, so I'll make them private for the moment (before intending to delete them in the future)
• change messaging when accessing under and overflow

Cheers, Philip

assigned to @psommer

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/PhotonEfficiencyCorrection

This merge request affects 3 files:

• PhysicsAnalysis/ElectronPhotonID/PhotonEfficiencyCorrection/PhotonEfficiencyCorrection/AsgPhotonEfficiencyCorrectionTool.h
• PhysicsAnalysis/ElectronPhotonID/PhotonEfficiencyCorrection/Root/AsgPhotonEfficiencyCorrectionTool.cxx
• PhysicsAnalysis/ElectronPhotonID/PhotonEfficiencyCorrection/Root/TPhotonEfficiencyCorrectionTool.cxx

added Analysis Egamma analysis-review-required master review-pending-level-1 labels

added analysis-review-approved label and removed analysis-review-required label

CI Result SUCCESS (hash 46c16b70)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57786]

Looks good, approving - L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit bb9a3cea

added sweep:ignore label