Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 162
    • Merge requests 162
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56212

Minor updates for mistimeMon chains

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Savanna Shaw requested to merge sshaw/athena:mistimemon-updates into 22.0 Aug 25, 2022
  • Overview 6
  • Commits 1
  • Pipelines 2
  • Changes 7

Adressing some comments from the MR that originally implemented the chains (!55264 (merged), ATR-19589). Namely:

  • Make the trigCOmposite object we create recordable and add it to the EDM (and make the 'pass' variable an int instead of bool) - cc @bernius and @okuprash
  • Attach the trigComposite as the feature in the hypo alg
  • Minor cleanup to initialisation of some vectors
  • Have the hypo alg trhow an error if we have more than one trigComposite object
Edited Sep 01, 2022 by Savanna Shaw
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mistimemon-updates