Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56226

LArG4Code: do not delete ILArCalculatorSvc

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Frank Winklmeier requested to merge fwinkl/athena:fwinkl_20220825T180035 into master Aug 25, 2022
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 2

LArG4SimpleSD and LArG4CalibSD are deleting the ILArCalculatorSvc on their destruction claiming they are "owning" it. That is certainly wrong as services are not owned by an individual component. Likely didn't cause problems so far because the G4 RunManager who ultimately triggers this destructor is not being cleaned up properly either.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fwinkl_20220825T180035