LArStraightAbsorbers+Electrodes: remove lazy initialization of members

Frank Winklmeierrequested to merge
fwinkl/athena:fwinkl_20220826T161421 into master

Similar to (!56268 (merged)) this makes several improvements to LArStraightAbsorbers and LArStraightElectodes:

  • Separate setters and getters for the internal values to avoid "filled" flag and inline the getters.
  • Explicitly pass PhysicalVolumeAccessor to SlantAbs/SlantEle and make it private.
  • Use static const initialization to avoid use of std::once.
  • Merge calculation of x and y values to avoid code duplication (should also be faster).
  • Use sincos.

Relates to ATLASRECTS-7235.

Edited by Frank Winklmeier

Merge request reports