Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56287

TrackingVolumeManipulator rm const_cast rm and UNSAFE annotations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Christos Anastopoulos requested to merge ATLAS-EGamma/athena:TrackingVolumeManipulator_rm_Const_cast into master Aug 27, 2022
  • Overview 14
  • Commits 9
  • Pipelines 3
  • Changes 88

This is the 1st followup of [!56242 (merged)]

Since in that one we finally avoid creating everything const. Now we are able to actually "manipulate" things without const_cast for a change ...

One has to look only on the following commit and any commits after that one until the previous MR is merged (ATLAS-EGamma/athena@cb90a633)

The true purpose / magic is the TrackingVolumeManipulator [https://gitlab.cern.ch/ATLAS-EGamma/athena/-/blob/cb90a633d968213901ee12e75213da5bdfca920e/Tracking/TrkDetDescr/TrkGeometry/src/TrackingVolumeManipulator.cxx] that now becomes THREAD_SAFE ping @fwinkl

There are one "syntactical" question I had on combining span and shared_ptr etc ... [ATLAS-EGamma/athena@cb90a633] ping @ssnyder with whom I discussed them. A mock perhaps easier to parse . [https://godbolt.org/z/MdzEjaYMG] (scroll around line 500)

Edited Aug 27, 2022 by Christos Anastopoulos
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: TrackingVolumeManipulator_rm_Const_cast