Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56301

JetCalibTools: Fix infinite loop in smearing correction

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged William Keaton Balunas requested to merge wbalunas/athena:jetRNG-220828 into master Aug 28, 2022
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 1

This fixes a problem introduced by !52501 (merged) which occasionally causes an infinite loop in JetSmearingCorrection.

The smearing correction is generated pseudo-randomly (but deterministically) using a seed based on the jet phi. If this would result in a negative jet pt or mass (i.e. you happen to sample a point far out in the left tail of the distribution), it tries again until it gets a non-negative result. !52501 (merged) changed the behavior to reset the seed to the same value at every attempt, resulting in an infinite loop. This fixes the problem by only setting the seed once before the first attempt.

Tagging @jbossios, who first encountered this, and @sawyer, @schaarsc, @sschramm.

Edited Sep 09, 2022 by Jonathan Bossio
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jetRNG-220828