Skip to content

LArDigitContainer: introduce p3 persistent representation and associated TP converter

Bertrand Martin Dit Latour requested to merge martindl/athena:R22_LArDigitContainerFix into 22.0

Hello,

As discussed in ATR-26276 and ATR-25881, this MR is introducing a new version for the LArDigitContainer persistent representation (p3 which supersedes p2), to handle both standard LAr cells and supercells. The name of the transient container is used to determine whether we are dealing with standard cells or supercells (in the latter case, the container name contains 'SC' by convention). The p3 converter design is completely based on p2, except that we now switch between LArOnlineID and LArOnline_SuperCellID helpers to do the mapping between IdentifierHash and HWIdentifier in the transient/persistent conversions, depending whether it's standard cells or supercells.

I would kindly ask @damazio , @ssnyder , @pavol , @wlampl , @jchapman to review this MR, thanks!

Cheers, Bertrand

Edit: following discussion in this MR, the actual deployment of p3 as the new default is deferred to a follow-up MR. This MR introduces all the necessary pieces, but keeps p2 as default, not to change the output.

Edited by Bertrand Martin Dit Latour

Merge request reports