Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 163
    • Merge requests 163
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56690

xAODRootAccess: thread-checker fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Frank Winklmeier requested to merge fwinkl/athena:xaodroot2 into master Sep 13, 2022
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 11

Mostly "cosmetic" thread-checker fixes as most of this code actually never runs multi-threaded:

  • xAOD::Init: use atomic_flag to serialise Init and various const fixes and warning suppressions. Also fix a bug where the return value of SetErrorHandler was used to judge if the error handler was installed. But the return value of that function is the previous signal handler. So there is no need to even store that value.
  • Mark TFileChecker as not thread-safe.
  • Remove unnecessary mutable in `TAuxVectorFactory.
  • Mark THolderCache and TDestructorRegistry singletons as thread-safe as all methods use mutexes.
  • Simplify singleton creation in TEventFormatRegistry.
  • Return const pointer in TEvent::getBranchInfo.
Edited Sep 13, 2022 by Frank Winklmeier
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: xaodroot2