Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 181
    • Merge requests 181
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56769

Add cut on m_minDecayRadiusQS to HEPMC3 version of GenParticleSimWhiteList::pass

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:WhiteListHepMC3Fix_master into master Sep 15, 2022
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

It was noticed that quasi-stable particle simulation output differed between HepMC2 and HepMC3 builds. The largest difference was due to the lack of a minimum decay radius cut for a particle to be considered as quasi-stable in HepMC3 builds. This merge request fixes this. NB the code change is within an #ifdef HEPMC3 block, so it will have no effect on the CI output, but has been tested locally.

After this, some particle ordering differences persist, but it is not clear whether these can be removed. This will be dealt with in a separate merge request if possible.

Tagging @tlari, @mbandier, @gcallea, @dhayden

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: WhiteListHepMC3Fix_master