Skip to content

MUCTPI BS converter: make topo decoding optional, refactor, small fixes

Rafal Bielski requested to merge rbielski/athena:muctpi-topo-option into 22.0

A follow-up to !56764 (merged) with the following changes:

  • Fix topo decoding output container name in python configuration.
  • Add new property DoTopo to make the topo decoding optional - default is false.
  • Add new ConfigFlag Trigger.L1.doMuonTopoInputs and set the DoTopo property to its value - default is false when not running L1Sim. In future the flag could also steer simulation outputs, but currently it doesn't.
  • Add new monitoring histograms for the topo decoding, similar to ones which already existed for RoI decoding.
  • Refactor the very long function MuonRoIByteStreamTool::convertFromBS by splitting the RoI decoding and Topo decoding into two new helper functions (similar to each other) decodeRoiSlices and decodeTopoSlices. This facilitates much cleaner application of the DoTopo flag logic.
  • Fix inconsistent indentation (mixed tabs and spaces).

The last two changes make it a bit tricky to review. Please notice many code changes are just moving code from convertFromBS to the two new helper functions.

Jira: ATR-25679

cc @czodrows

Edited by Rafal Bielski

Merge request reports