Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 189
    • Merge requests 189
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56928

gFex TOB ByteStream decoder update to allow for multiple TOB slices

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Cecilia Tosciri requested to merge ctosciri/athena:gFex_BS_multipleTOBslices into 22.0 Sep 21, 2022
  • Overview 23
  • Commits 3
  • Pipelines 2
  • Changes 3

With this MR, the gFex ByteStream decoder tool is updated to allow for multiple TOB slices (corresponding to consecutive BC). It previously worked in such a way that only one TOB slice per accepted event was decoded, with a fixed total number of gFex raw words decoded per event. This approach was leading to wrong decoding every time that the data frame contains multiple (typically 3) TOB slices. This is often the case for cosmics and calibration data. Now, depending on the slice number, the decoder is able to decode all kinds of data.

Tagging @rbielski to inform you that the zero words masking introduced in !56819 (merged) and discussed in ATR-25495 has been removed, as I realized that the only zero words that are now accepted and used to fill the containers are objects (Rho and JwoJ Scalar TOBs) that are not yet evaluated in firmware, and these objects being zero shouldn't throw any exception. To verify it, I tested the HLTSeeding code with the update, and no exceptions are indeed thrown. However, should this cause any problem, I will reintroduce (temporarily) the masking.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gFex_BS_multipleTOBslices