Remove Detector Identifier dependency from EDM package
This is a followup of !56810 (merged) (actually we'll ned this one in first) It turned out that we have a problem having dependency on Detector Identifier in xAOD classes in AnalysisBase project. With this changes the type of identifier becomes essentially unsigned int. Client codes in: InDetPrepRawDataFormation and ActsTrkAnalysis compile (thanks to assignments operators for this class I guess: https://gitlab.cern.ch/atlas/athena/-/blob/master/DetectorDescription/Identifier/Identifier/Identifier.h)
FI @akraszna @pagessin @cvarni @toyamaza Addresses part of: ATLIDTRKCP-388
In particular, comment on the typedef xAOD::DetectorIDHashType
.
Merge request reports
Activity
This merge request affects 1 package:
- Event/xAOD/xAODMeasurementBase
This merge request affects 3 files:
- Event/xAOD/xAODMeasurementBase/CMakeLists.txt
- Event/xAOD/xAODMeasurementBase/Root/UncalibratedMeasurement_v1.cxx
- Event/xAOD/xAODMeasurementBase/xAODMeasurementBase/versions/UncalibratedMeasurement_v1.h
Adding @akraszna as watcher
added EDM analysis-review-required master review-pending-level-1 labels
CI Result SUCCESS (hash 87563fd7)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 59458]added review-approved label and removed review-pending-level-1 label
added analysis-review-approved label and removed analysis-review-required label
- Resolved by Edward Moyse
As per description, will wait for !56810 (merged) to be merged first.
added RC Attention Required label
removed RC Attention Required label
mentioned in commit 86f60266
added sweep:ignore label