Skip to content

Implementing better return codes in PhotonEfficiencyCorrection

Philip Sommer requested to merge ATLAS-EGamma/athena:philip_photonEffReturnCodes into master

This MR implements proper return codes in AsgPhotonEfficiencyCorrection. This automatically improves our CI test and gives us some level of protection when releasing new recommendations.

On the way, I found a small bug when calculating the immutable photon pT: it was inconsistent with what we run in reco. The new version is consistent with reco, c.f. here.

I removed the use of the T-tool from PrintPhotonSF.cxx ... I haven't found anyone who used it recently, so I assume it's fine.

Cheers, Philip

FYI @fnechans, @kliu, @nproklov

Edited by Philip Sommer

Merge request reports