Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 168
    • Merge requests 168
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !57366

Fixed FPE in NSW Trigger Simulation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Francesco Giuseppe Gravili requested to merge fgravili/athena:fpe into 22.0 Oct 07, 2022
  • Overview 4
  • Commits 4
  • Pipelines 0
  • Changes 3

As reported in ATR-24638, several floating point exceptions (FPE) were found when running the NSWL1Simulation. This MR fixes them, with a few additional and related changes:

  • Removed extra spaces and unused functions
  • Replaced deprecated TVector instances with ROOT::Math::XYZVector ones
  • Replaced hard-coded formulas with inbuilt functions of the aforementioned objects
Edited Oct 08, 2022 by Francesco Giuseppe Gravili
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fpe