This MR fixes what was most likely a typo in the past. The
TrkMuonSegment container contains all muon segments that were used in the reconstruction of a muon while the
TrackMuonSegment contains all muon segments that were reconstructed, independent of whether they were used for a muon. So far the individual container (one container for associated, unassociated and NSW segments) where written out on xAOD level and the overall container on the Trk::Segment level which brakes the navigation between xAOD and Trk segments. In addition to this change also the Trk::Segment container for the NSW segments is written out to allow residual studies in the NSW.
The size of the ESD should only change due to the addition of the NSW segment container. For the muons it should stay the same since
Trk::UnAssocMuonSegments are orthogonal to each other and
Trk::TrackMuonSegments is the sum of the two.
Since this is a bigger change let me request full-unit-tests. Since the content of the ESDs will change this will most likely be frozen-tier0-violating but lets see what the CI says.
Finally let me add some people who might be interested in this change: @jojungge @rosati @giraudpf @amelung @ngarelli @makbiyik