separate super-cell functionality of LArRawChannelBuilderAlg into dedicated LArRawChannelSCAlg
Hi @damazio,
I believe the SuperCell version of the LArRawChannel building is sufficiently different from the regular LArRawChannel-Building to justify a dedicated Algorithm - instead of more than 10 statements like if (m_isSC)
in one algorithm.
This MR creates a dedicated LArRawChannelBuilderSCAlg. I'll clean out the SC-functionality from the LArRawChannelBuilderAlg once @nsur's MR is accepted.
Merge request reports
Activity
This merge request affects 1 package:
- LArCalorimeter/LArROD
This merge request affects 5 files:
- LArCalorimeter/LArROD/python/LArSuperCellBuilderAlgDefault.py
- LArCalorimeter/LArROD/python/LArSuperCellBuilderConfig.py
- LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.cxx
- LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.h
- LArCalorimeter/LArROD/src/components/LArROD_entries.cxx
added Run3-MCOverlay-output-changed label
CI Result FAILURE (hash 64514ebc)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 60515]The issues found in the CI where twofold:
- Quality-factor difference due to a bug in my implementation, fixed now
- Last-digit differences of the cell-time because in the supercell code-path of the current LArRawChannelBuilderAlg, the time gets converted back and forth between nanoseconds and picoseconds.
This merge request affects 1 package:
- LArCalorimeter/LArROD
This merge request affects 5 files:
- LArCalorimeter/LArROD/python/LArSuperCellBuilderAlgDefault.py
- LArCalorimeter/LArROD/python/LArSuperCellBuilderConfig.py
- LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.cxx
- LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.h
- LArCalorimeter/LArROD/src/components/LArROD_entries.cxx
CI Result SUCCESS (hash d0290ed9)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 60608]removed Run3-MCOverlay-output-changed label
added 1 commit
- fa528641 - Revert "add deliberate nonsense to reproduce previous behaviour"
This merge request affects 1 package:
- LArCalorimeter/LArROD
This merge request affects 5 files:
- LArCalorimeter/LArROD/python/LArSuperCellBuilderAlgDefault.py
- LArCalorimeter/LArROD/python/LArSuperCellBuilderConfig.py
- LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.cxx
- LArCalorimeter/LArROD/src/LArRawChannelBuilderSCAlg.h
- LArCalorimeter/LArROD/src/components/LArROD_entries.cxx
added Run3-MCOverlay-output-changed label