Skip to content

Draft: FitQualityOnSurface make it trivial Moved to !58002

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:FitQualityOnSurface_pod into master

Moved to !58002 (merged)

We seem to have

  • FitQuality (refers to Track or Segment) that needs to be expandable and so have virtual methods (and therefore vptr)

  • FitQualityOnSurface . We have much more of them around . And for them we seem to need just the basic part

  • This tries to achieve this. The only gain here for this MR would be the vptr so FitQualityOnSurface will have 2/3 the size wrt before.

  • Now, It seems that most (almost all) TSOS have a fitquality attached when created.

  • So in principle as a second step (main gain) one could even attempt to change here [https://gitlab.cern.ch/atlas/athena/-/blob/master/Tracking/TrkEvent/TrkTrack/TrkTrack/TrackStateOnSurface.h] to using "value semantics" which prb would get rid of quite a few small allocations all over the place , per event (and prb improve locality)

pinging @sroe, @amete.

Edited by Christos Anastopoulos

Merge request reports