LArG4GenShowerLib+LArG4FastSimulation+LArG4Validation: Fix cppcheck warnings.

Prefer preincrement to postincrement for user iterators. Pass strings by const reference, not by value. Prefer range-for.