Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 165
    • Merge requests 165
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !58065

PoolSvc: thread-checker cleanup and extra locking

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Frank Winklmeier requested to merge fwinkl/athena:poolsvc into master Nov 03, 2022
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 4

PoolSvc::createCollection was marked as not thread-safe due to the use of the pool::CollectionFactory singleton. Use the general PoolSvc mutex to protect access to it and mark it as safe.

Also lock when calling registerPFN on the catalog as it is not clear to me if the context-specific persistency lock is good enough.

Finally remove some unnecessary mutable, thread-checker annotations and update link dependencies.

cc @gemmeren @mnowak

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: poolsvc