TSOS: keep FitQualityOnsurface as value. Re-organise constructors
This is the 1st (?) continuation of !58002 (merged) (clean version of !58006 (closed))
- Store the FitQualityOnSurface in the TSOS as a value (rather than ptr)
- Rationalize the ctors
- Migrate clients
Probably will do another 1-2 follow up. But this one is should be the large one, i.e the one that needs touching multiple files. The change is "repetive" 1-2 line change in 70 files .
ping @sroe and perhaps @abarton .
There are 2 things one can do for sure in the near future.
-
One is that in principle since we pay the cost of virtual and DataVector and we sub classing TSOS the
Alignment
should be part of the base, but should come similarly the MutliComponents are done. Here one prb can make a bit clear design. Note that _p3 does not have Alignement effects on Track (or Multi Component) [https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Tracking/TrkEventCnv/TrkEventTPCnv/TrkEventTPCnv/TrkTrack/TrackStateOnSurface_p3.h#0018]. -
The other is that the updators (kalman etc ones) prb can now return FitQualityOnSurface and we should also avoid ptr in the relevant places.