Skip to content

Update IInputConverter::convert() definition

John Derek Chapman requested to merge jchapman/athena:InputConverterConstness_master into master

Although the ISF_InputConveter::convert method does not alter the contents of the McEventCollection itself, it sets up TruthBinding objects which can be used to update the contents of the McEventCollection. For this reason we should not mark the McEventCollection argument of this method as const. Similarly TruthBinding objects hold GenParticlePtr instances, so we should not use ConstGenParticlePtr in the intermediate methods, then cast away the constness at the end.

Tagging @christos and @fwinkl for comments before undrafting.

Edited by John Derek Chapman

Merge request reports