FPTracker: make IBeamline elements non-const

The beamline elements are being calibrated (e.g. collimator positions are determined) when setting up. Make them and the calibrate method non-const to avoid mutables.

Enable thread-checker.

This merge request affects 1 package:

• ForwardDetectors/FPTracker

This merge request affects 18 files:

• ForwardDetectors/FPTracker/FPTracker/ATLAS_CHECK_THREAD_SAFETY
• ForwardDetectors/FPTracker/FPTracker/Beamline.h
• ForwardDetectors/FPTracker/FPTracker/Collimator.h
• ForwardDetectors/FPTracker/FPTracker/EmptySpaceElement.h
• ForwardDetectors/FPTracker/FPTracker/IBeamElement.h
• ForwardDetectors/FPTracker/FPTracker/Magnet.h
• ForwardDetectors/FPTracker/FPTracker/Plane.h
• ForwardDetectors/FPTracker/FPTracker/SolenoidElement.h
• ForwardDetectors/FPTracker/FPTracker/magnetFactory.h
• ForwardDetectors/FPTracker/src/Beamline.cxx
• ForwardDetectors/FPTracker/src/Collimator.cxx
• ForwardDetectors/FPTracker/src/EmptySpaceElement.cxx
• ForwardDetectors/FPTracker/src/Magnet.cxx
• ForwardDetectors/FPTracker/src/Plane.cxx
• ForwardDetectors/FPTracker/src/collSet.cxx
• ForwardDetectors/FPTracker/src/magnetFactory.cxx
• ForwardDetectors/FPTracker/src/magnetSet.cxx
• ForwardDetectors/FPTracker/src/setupBeamline.cxx

added ForwardDetectors master review-pending-level-1 labels

CI Result SUCCESS (hash e2afd03e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61652]

Approved, Hans (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit cab10618

added sweep:ignore label