Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 159
    • Merge requests 159
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !58339

Remove the MuonSegmentMergerTool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Johannes Junggeburth requested to merge jojungge/athena:shovel_segMerger into master Nov 11, 2022
  • Overview 100
  • Commits 6
  • Pipelines 0
  • Changes 13

Hi everybody,

the IMuonSegmentMergerTool is a living zombie as the interface is effectively included only in the MuonTrackSteering but always switched off. The implementation suffers from a lot of potential memory leaks. So the best is just to remove this tool.

The advantage is that the IMuonSegmentTriggerHitAssociator is also fully unused and we can remove this functionality from the DCMathSegmentMaker as well and remove the interface from the code base.

The changes in the DCMathSegmentMaker remove a couple of unnecessary copies and ranged for loops.

Edited Nov 11, 2022 by Johannes Junggeburth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: shovel_segMerger