Skip to content

Fix eta == 2.5 selection inconsistency in MCP tools

Oliver Majersky requested to merge omajersk/athena:mcp-fix-eta2p5 into master

This MR proposes a change in the MuonSelectorTools to make muons with |eta| == maxEta to fail the selection. When selecting muons with maxEta = 2.5, this makes it consistent with the treatment of scale factors here, where SFs for muons with eta >= 2.5 are read from "forward" efficiency files.

I've come across this bug only by chance, since there are no SF maps for muons with eta >= 2.5 for mc21, and the code therefore crashes on extremely rare occasion, where a muon with eta == 2.5 passes selection and then no maps can be retrieved.

I'm not an expert on treatment of floats in C++, but I imagine the whole >= vs > is sketchy, but this at least makes the behavior between selection and SF map retrieval consistent, and avoids the rare annoying crash.

Tagging @jojungge and @stavrop

Merge request reports