Skip to content
Snippets Groups Projects

Address Thread-checker warnings in `Charginos`, `Gauginos` and `Sleptons` packages

All threads resolved!

Creation of G4ParticleDefinition objects occurs during the initialization of Geant4 which is done in a single thread. The syntax used in the Charginos, Gauginos and Sleptons packages follows the syntax used in Geant4:
https://gitlab.cern.ch/atlas-simulation-team/geant4/-/blob/v10.6.3.4/source/particles/leptons/include/G4Electron.hh
https://gitlab.cern.ch/atlas-simulation-team/geant4/-/blob/v10.6.3.4/source/particles/leptons/src/G4Electron.cc
For now we mark the static s_theInstance/theInstance variables as ATLAS_THREAD_SAFE until such time as the syntax is updated to something neater on the Geant4 side.

Tagging @christos and @fwinkl

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 0226abfc - Add explanatory comments where ATLAS_THREAD_SAFE is used

    Compare with previous version

  • John Derek Chapman resolved all threads

    resolved all threads

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • This merge request affects 3 packages:

    • Simulation/G4Extensions/Charginos
    • Simulation/G4Extensions/Gauginos
    • Simulation/G4Extensions/Sleptons

    Affected files list will not be printed in this case

    Adding @jchapman as watcher

  • :white_check_mark: CI Result SUCCESS (hash 6bc5eca2)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62178]

  • :white_check_mark: CI Result SUCCESS (hash 0226abfc)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62180]

  • Approving - L1

  • mentioned in commit 1b70328f

  • Please register or sign in to reply
    Loading