CaloTools; Protect against clang speculative evaluation.
In CaloNoiseCondAlg, clang may speculatively evaluate sqrt(lumi) even if due to m_noiseType it does not actually get used. However, in that case, it is possible that lumi is negative. This then leads to issues if one is looking at the results of FPEs.
Protect against this by ensuring that lumi is non-negative, even if the sqrt may not be evaluated. Needed to fix failure of FastCaloSim test in the clang build.
Merge request reports
Activity
This merge request affects 1 package:
- Calorimeter/CaloTools
This merge request affects 1 file:
- Calorimeter/CaloTools/src/CaloNoiseCondAlg.cxx
Adding @pavol as watcher
added Calorimeter JetEtmiss master review-pending-level-1 labels
CI Result SUCCESS (hash 99be29e6) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62209] removed review-pending-level-1 label
added review-approved label
mentioned in commit 2459e0b3
added sweep:ignore label