Skip to content
Snippets Groups Projects

CaloTools; Protect against clang speculative evaluation.

Merged Scott Snyder requested to merge ssnyder/athena:fpe.CaloTools-20221121 into master

In CaloNoiseCondAlg, clang may speculatively evaluate sqrt(lumi) even if due to m_noiseType it does not actually get used. However, in that case, it is possible that lumi is negative. This then leads to issues if one is looking at the results of FPEs.

Protect against this by ensuring that lumi is non-negative, even if the sqrt may not be evaluated. Needed to fix failure of FastCaloSim test in the clang build.

Merge request reports

Pipeline #4793628 passed

Pipeline passed for 99be29e6 on ssnyder:fpe.CaloTools-20221121

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 2 years ago (Nov 22, 2022 12:13pm UTC)

Merge details

  • Changes merged into master with 2459e0b3 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading