Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 179
    • Merge requests 179
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !58655

add ActsTrkFinding to use ACTS CKF

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tim Adye requested to merge adye/athena:23.0.9-adye into master Nov 23, 2022
  • Overview 133
  • Commits 47
  • Pipelines 3
  • Changes 26

A first implementation of ActsTrkFinding/TrackFindingAlg and ActsTrkFindingTool/TrackFindingTool to use Acts::CombinatorialKalmanFilter from Athena.

  • With --preInclude ActsInterop.ActsCIFlags.actsValidateTracksFlags:
    • replaces Athena track finding with Acts track finding. Subsequent steps use Acts Trk::Track outputs, so default IDPVM can be used for performance studies.
      • It looks good so far, with one big exception: a large loss of efficiency in the barrel, probably due to loss of most strip hits.
    • also replaces the Acts clusterization with the Athena clusterization in the Acts workflow. This is needed to create PRD links, which are needed while we use Trk::Track as output of the track finding.
  • To-do following this MR:
    • fix strip hit association
    • revisit tool interface, or move tool functionality into algorithm.
    • improve Trk::Track creation or replace with new Acts::Track. For Trk::Track:
      • does not add outliers from reverse filtering - is this needed?
      • uses legacy Athena enums, Trk::TrackInfo::TrackFitter::KalmanFitter and Trk::TrackInfo::TrackPatternRecoInfo::SiSPSeededFinder
      • only works with Athena clusterization
      • Unlike Athena algorithm, no additional fit required after Acts CKF. We should disable the global Chi^2 fit in the ambiguity solver.
      • are we using the correct TSOS to calculate the track parameters?

Implements ATLIDTRKCP-355. Details and performance discussed here.

Edited Jan 20, 2023 by Tim Adye
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 23.0.9-adye