Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !58709

Draft: MuonTrack fitting - Revise the hit sorting & recovery

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Johannes Junggeburth requested to merge jojungge/athena:ATLASRECTS-7393 into master Nov 25, 2022
  • Overview 26
  • Commits 1
  • Pipelines 0
  • Changes 18

Moin everybody,

initially triggered by these harmless appearing WARNINGS

RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle
RAWtoALL 09:00:19 MuonCombinedAlg.MuonCom...CombinedMuonTrackBuilder   407     4 WARNING appendSelectedTSOS:: skip duplicate measurement of type drift circle

I dug into the two rabbit holes: The hit sorting & counting in the MuPatTrackBuilder and the hit recovery throughout the muon chain.

  • Hit sorting on the MS track: If two hit lists are merged, the track parameters of one list are recalculated. I.e., the extrapolator is launched to extrapolate the surface parameters In addition, the complete method of adding the hit to the list is horribly complicated :scream::scream::scream:. The sorting is now simplified drastically exploiting the centers of the associated readout element. In rare cases, it can happen that 2 cluster hits from the same layers are added to the track fit. These hits are then sorted by their respective residual pull and removed later

  • MuonChamberHoleRecoveryTool:

data22_13p6TeV spot test:

Algorithm Time per event (22.0) Time per event (patch)
MuPatTrackBuilder 163 145
MuPatTrackBuilder_EMEO 182 180
MuonCombinedMuonCandidateAlg 143 115
MuonCombinedMuonCandidateAlg_EMEO 70 70
MuonCombinedAlg 151 130
MuonCombinedAlg_EMEO 103 81
MuonCombined_LRT 19 13
MuonInsideOutRecoAlg 204 145
MuGrilAlg_LRT 64 47

Closes ATLASRECTS-7393/ATLASRECTS-7391/ATLASRECTS-6713

Targets: ATLASRECTS-6791/ATLASRECTS-6811/ATLASRECTS-6792

Edited Feb 01, 2023 by Johannes Junggeburth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ATLASRECTS-7393