Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 145
    • Merge requests 145
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !58866

Fix for sTGC as-built conditions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Stylianos Angelidakis requested to merge sangelid/athena:dev_asbuilt into 22.0 Nov 30, 2022
  • Overview 16
  • Commits 4
  • Pipelines 3
  • Changes 7

Some optimizations in view of as-built conditions:

  1. Bugfix: For sTGC's we measure strips in pitches, (3.2mm), not width (2.7mm).
  2. Optimized the sTGC as-built transformation to handle positions between strips, as it is for MM (not to put everything on the strip center).
  3. Some protection for layers or cathode board elements that may not have as-built corrections at all.
  4. Finally, I noticed that the B-field correction can kick a cluster position slightly out of the active area (only for clusters on the very outmost strips). It's not the job of the as-built transformation to reject those cases, just to correctly apply the transformation. Applied the necessary change for this.

Tagging @stsigari

Edited Dec 01, 2022 by Stylianos Angelidakis
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev_asbuilt