Externals Updates, master branch (2022.12.02.)

Upgraded all projects to atlasexternals-2.0.145. It brings the following updates wrt. atlasexternals-2.0.144 (atlasexternals@2.0.144...2.0.145):

• Made sure that autoconf/automake based externals would build successfully with CMake >=3.24;
  • This should finally make it possible to switch the master nightlies and the CI to CMake 3.24.3, as discussed in ATLINFR-4765;
• Upgraded the externals in AnalysisBaseExternals to be in sync with LCG_102b_ATLAS_2 (thanks to @elmsheus).

At the same time updated AthAnalysis to use LCG_102b_ATLAS_6, once again in sync with all of the other LCG based projects. (There are some tiny differences between LCG_102b_ATLAS_2 and LCG_102b_ATLAS_6, so the analysis releases will need to be tweaked a bit further later on. But this agreement should be "good enough" to finally get AthAnalysis back in sync with everything else.)

Turning on both full-build and full-unit-tests due to the big external changes in the analysis releases.

Also tagging @krumnack and @amehta.

added full-build full-unit-tests labels

Build area was cleaned as per request posted in the DB. The full software build will be performed

build area is cleaned as MR is labeled as full-build

This merge request affects 9 packages:

• Projects/AnalysisBase
• Projects/AthAnalysis
• Projects/AthDataQuality
• Projects/AthDerivation
• Projects/AthGeneration
• Projects/AthSimulation
• Projects/Athena
• Projects/DetCommon
• Projects/VP1Light

Affected files list will not be printed in this case

Adding @krumnack ,@jchapman ,@akraszna ,@rbianchi as watchers

added Build master review-pending-level-1 labels

CI Result FAILURE (hash 1886a8cb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62939]

added 26 commits

• 1886a8cb...1c3fde0a - 24 commits from branch atlas:master
• 3c19f6bf - Upgraded all projects to atlasexternals-2.0.145.
• 16405058 - Prevented GCC from thinking that null pointers would be used.

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

build area is cleaned as MR is labeled as full-build

This merge request affects 10 packages:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections
• Projects/AnalysisBase
• Projects/AthAnalysis
• Projects/AthDataQuality
• Projects/AthDerivation
• Projects/AthGeneration
• Projects/AthSimulation
• Projects/Athena
• Projects/DetCommon
• Projects/VP1Light

Affected files list will not be printed in this case

Adding @jchapman ,@fsforza ,@stavrop ,@szambito ,@jojungge ,@apsallid ,@krumnack ,@akraszna ,@mvanadia ,@gabarone ,@gartoni ,@rbianchi as watchers

added Analysis analysis-review-required labels

A couple of things:

• I finally understood why warnings about Boost were missing in the offline projects. Because @elmsheus added -DBoost_NO_WARN_NEW_VERSIONS=TRUE flags to all of their builds. Now I added that for AnalysisBase and AthAnalysis as well.
• The warning in the build of AnalysisBaseExternals will not be possible to fix in this MR. It is coming from Davix, and is the following:

CMake Warning at CMakeLists.txt:51 (message):
  the curl cmake build system is poorly maintained.  Be aware

• The warning that showed up only in AnalysisBase about the MuonMomentumCorrections code was very interesting. But in the end the noteworthy thing about it is that I used git-clang-format on my changes, making use of the format introduced in !58781 (merged). The formatting turned out to be a bit more "widespread" than I would've expected. So I'm open to feedback. Especially from @fwinkl.

CI Result FAILURE (hash 16405058)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 62999]

removed review-pending-level-1 label

added review-user-action-required label

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

build area is cleaned as MR is labeled as full-build

This merge request affects 10 packages:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections
• Projects/AnalysisBase
• Projects/AthAnalysis
• Projects/AthDataQuality
• Projects/AthDerivation
• Projects/AthGeneration
• Projects/AthSimulation
• Projects/Athena
• Projects/DetCommon
• Projects/VP1Light

Affected files list will not be printed in this case

Adding @jchapman ,@fsforza ,@stavrop ,@szambito ,@jojungge ,@apsallid ,@krumnack ,@akraszna ,@mvanadia ,@gabarone ,@gartoni ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 16405058)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63020]

added 2 commits

• 79def6c3 - Upgraded all projects to atlasexternals-2.0.145.
• e551c3f2 - Prevented GCC from thinking that null pointers would be used.

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

build area is cleaned as MR is labeled as full-build

Apparently the ATLAS_<FOO>_PATCH commands are not useless after all. I was able to silence the warning in Davix using ATLAS_DAVIX_PATCH. Let's hope that the CI agrees.

This merge request affects 10 packages:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections
• Projects/AnalysisBase
• Projects/AthAnalysis
• Projects/AthDataQuality
• Projects/AthDerivation
• Projects/AthGeneration
• Projects/AthSimulation
• Projects/Athena
• Projects/DetCommon
• Projects/VP1Light

Affected files list will not be printed in this case

Adding @jchapman ,@fsforza ,@stavrop ,@szambito ,@jojungge ,@apsallid ,@krumnack ,@akraszna ,@mvanadia ,@gabarone ,@gartoni ,@rbianchi as watchers

Bumping up to AR expert

Giovanni (AR)

added analysis-review-expert label

removed analysis-review-required label

CI Result FAILURE (hash e551c3f2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 63026]

At this point I would declare victory. The following CTest-s fail in Athena:

The following tests FAILED:
	189 - CaloRec_CaloCellMakerTest_ctest (Failed)
	344 - AthExHive_AthExHiveCond_test_ctest (Timeout)
	2135 - L1CaloFEXSim_L1CaloFEXSimCfg_R2data_ctest (Failed)

The timeout is unfortunate... But the other two are failing in the latest nightly as well.

• http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7G11AthenaOpt/ARDOC_TestLog_2022-12-03T2101/Calorimeter_CaloRec___CaloRecConf__CaloRecTest__m.html
• http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7G11AthenaOpt/ARDOC_TestLog_2022-12-03T2101/Trigger_TrigT1_L1CaloFEX_L1CaloFEXSim___L1CaloFEXSimConf__L1CaloFEXSimTest__m.html

So I don't think the CI needs to be re-run anymore.

yes

Let me ping @pavol @wlampl and @tsulaia , it is not clear to me what exactly is the issue from the logs I see

FPEAuditor                                           INFO FPE summary for this job
FPEAuditor                                           INFO  FPE OVERFLOWs  : 0
FPEAuditor                                           INFO  FPE INVALIDs   : 0
FPEAuditor                                           INFO  FPE DIVBYZEROs : 0
ApplicationMgr                                       INFO Application Manager Finalized successfully
ApplicationMgr                                       INFO Application Manager Terminated successfully

so I assume is some log change for the failed calo test .... Seems to start friday or so ... perhaps we need a JIRA although there might be some MRs ongoing

added analysis-review-approved label and removed analysis-review-expert label

I'm inclining to merge this one and the ACTS bump tonight.

Any objections? (/cc @jmaurer @janders)

added review-user-action-required label and removed review-pending-level-1 label

Marking this as user-action-required while there are open threads.

Cheers

L1

removed review-user-action-required label

added review-approved label

added review-approved-tier0 label

added review-approved-point1 label

resolved all threads

merged

mentioned in commit e7ba648e

added sweep:ignore label