Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 169
    • Merge requests 169
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !59034

Fixed thread checker warnings for AthenaMPTools

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vakhtang Tsulaia requested to merge tsulaia/athena:master-mptools into master Dec 06, 2022
  • Overview 9
  • Commits 1
  • Pipelines 3
  • Changes 12

Declared several virtual functions in the AthenaMPTools and AthenaInterprocess packages ATLAS_NOT_THREAD_SAFE.

Affected functions:

  • IMessageDecoder::operator()()
  • Process::mainloop()
  • IAthenaMPTool::makePool()
  • IAthenaMPTool::exec()
  • IAthenaMPTool::wait_once()
  • AthenaMPToolBase::exec_func()
  • EvtRangeScatterer::getNewRangeRequest()

Declared AthMpEvtLoopMgr ATLAS_NOT_THREAD_SAFE

Some of these changes will be reverted after yampl gets patched, as discussed here.

Addresses ATEAM-868

Edited Dec 07, 2022 by Vakhtang Tsulaia
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-mptools