Skip to content

23.0-cppcheck-PixelCalibAlgs

Shaun Roe requested to merge sroe/athena:23.0-cppcheck-PixelCalibAlgs into master

Solve cppcheck defects; in particular multiple out-of-bounds access in the CalibrateIBL macro caused by confusing the functionality of reserve() and resize() on a std::vector (@stsuno), solved by switching to std::array. Also one possible access at negative index, multiple redundant checking for nullptr before delete, and some minor performance defects (use of postincrememnt instead of preincrement on iterators)

This code is a root macro and is not executed in any normal workflow, it is exclusively for calibration.

Merge request reports

Loading