Skip to content

TrigT1NSWSimTools: skip calculations with early return in MMT_Road

Bertrand Martin Dit Latour requested to merge martindl/athena:MMT_Road_EarlyReturn into master

Hello,

This MR is trying to optimise 2 methods in MMT_Road by skipping calculations when possible, moving a 'return' at the beginning of the method. The gain in CPU time for NSWL1Simulation (ATR-25528) seems sizeable (6% faster, evaluated on 500 MC21a ttbar events).

A diff-root on 100 AOD events shows:

Py:diff-root         INFO 210.UnAssocMuonSegmentsAuxDyn.clusterTime.11.214.UnAssocMuonSegmentsAuxDyn.clusterTime.11 55.95338821411133 -> 56.240901947021484 => diff= [-0.12813207%]

Maybe among the expected irreproducibilities, I would have expected this MR not to change the output.

Tagging @fgravili and @jojungge for expert review.

Cheers, Bertrand

Edited by Bertrand Martin Dit Latour

Merge request reports