Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 181
    • Merge requests 181
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !59099

add options to and factories for the remaining analysis configuration blocks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nils Erik Krumnack requested to merge krumnack/athena:more_options into master Dec 08, 2022
  • Overview 23
  • Commits 2
  • Pipelines 4
  • Changes 17

This tries to give the same treatment given to muons and photons to all the other configurations, so that it should be possible to configure all the blocks just through the options and instantiate them through the common factory.

There is probably some cleanup that could be done here in the future, regarding what some of the configuration blocks should be called exactly, what the options exposed should be etc. The main goal of this update is that I can now (more or less awkwardly) set everything I can via options that was previously limited to named parameters to the various make...Config() calls, and to replace the individual make...Config() calls with the generic makeConfig() factory.

I also added customizable behavior for setting a value of None on an option. There are several possible behaviors that could make sense or that the user may expect, so I didn't want to fix a specific one now, but I needed to be able to rely on one when creating the default blocks.

Edited Dec 13, 2022 by Nils Erik Krumnack
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: more_options