Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 158
    • Merge requests 158
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !59145

Switch to using VectorDoubleAttribute for GenVertex weights for consistency with internal HepMC3 code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:doubleweights into master Dec 10, 2022
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 11

The HepMC3 WriterAsciiHepMC2 assumes VectorDoubleAttribute has been used for the GenVertex "weights" property. As this class is used in a couple of places in the Athena code. We have to follow this convention in our transient GenVertex EDM, even though the information is persistified as std::vector<float>.

As there don't seem to be any clients for this information after an initial inspection, it may be that we can drop this information from the transient EDM in the future. We need to confirm that there are no clients first though.

Tagging @tadej, @averbyts.

Replaces !59134 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: doubleweights