Skip to content

Bug Fix for external files added to tarball sent to the grid when using `EL::PrunDriver`

Romain Bouquet requested to merge robouque/athena:bouquet_21.2_ELGridSubmissionExtFile into 21.2

I found an issue when someone wants to add external files to be added to the tarball sent to the grid with the EL::PrunDriver It consists in a one line change.

The

sample.meta().castString('nc_EventLoop_UserFiles')

returns a string provided by the user that contains the file names to be added to the tarball (additionally to the content of the build directory).

And so the call of

",".join (sample.meta().castString('nc_EventLoop_UserFiles'))

was adding a comma between each character contained in the string.
While we want to add a comma between each file names provided by the user (in case file names are space separated instead of comma separated). The change is precisely doing that by replacing all space in the nc_EventLoop_UserFiles string by comma.

This was causing instability when submitting jobs with the EL::PrunDriver when adding external files (the tarball building was sometimes failing I believe because of that issue)

The changes have been successfully tested with the CxAODFramework

Tagging @krumnack on that issue

(And just for information tagging @yama, @eschopf and @hanar)

Edited by Romain Bouquet

Merge request reports