Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 169
    • Merge requests 169
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !59308

eFEX offline simulation fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Will Buttinger requested to merge will/athena:fixRounding into master Dec 14, 2022
  • Overview 95
  • Commits 22
  • Pipelines 12
  • Changes 22

A collection of fixes to simulation based on comparisons between recorded real output and emulated (re-simulated) output.

  • supercell masking using LAr provenance bits
  • eta dependent menu fix
  • the overflow is taken care off in expansion
  • tau sum is over layer 2 only
  • implement max threshold counts for Taus
  • the hardware counts down rather than up
  • no longer overwrite the tau working points
  • deal with wstot max value
  • fix rounding of float values, to allow for negative values ... should all be ints
Edited Jan 25, 2023 by Will Buttinger
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fixRounding