Skip to content

Add extra words to CTP ROD data payload in CTPSimulation

Rafal Bielski requested to merge rbielski/athena:ctp-writebs-extrawords into master
  1. Implement missing features in CTP Simulation:
    • Support for "extra words" as defined in the data format specification.
    • Correct setting of the data format word in the simulated RoIB fragment (encoded in ROD minor version word). This format word contains the count of "extra words" and the CTP version number.
  2. Add six empty "extra words" to the simulated CTP output by default. This is required to allow changing prescale keys when running TDAQ partition with preloaded data, where the data contain simulated CTP outputs. This is a typical use case for HLT tests in TDAQ Technical Runs at P1. This hopefully fixes ATR-24654.
  3. Given the CTP data format word in simulated RoIBResult is now correct (see 1.), remove the extra calculation of this word in RoIBResultByteStreamTool which was based on the CTP_RDO object. This allows to completely remove the dependency of this tool on CTP_RDO. This is a better fix for ATR-23181 than the hacky !43035 (merged) which worked around the missing features in CTPSimulation.

FYI @czodrows

For RC: Please do not squash. Points 1-2 and point 3 are separate commits in independent packages.

Merge request reports